fix: Treat item as dict TDE-1209
#993
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We load the item from a JSON file into a `dict` in the production code, but none of our automated tests verify this code path, so it broke. This partially reverts commit ed177c6.
l0b0
force-pushed
the
fix/imagery-item-dict
branch
from
dea8fbf to
d191eb0
Compare
amfage
approved these changes
Jun 19, 2024
Merged
3 tasks
blacha
approved these changes
Jul 1, 2024
amfage
added a commit
that referenced
this pull request
Jul 7, 2024
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
#### Motivation Revert Pull Requests #993 and #985 #985 caused [collection_from_item to fail](https://toitutewhenua.atlassian.net/browse/TDE-1209) and while #985 resolved that issue, it [creates invalid STAC Items](https://toitutewhenua.atlassian.net/browse/TDE-1217). Unit tests and GitHub Actions tests did not pick up these issues. #### Modification Revert commits 384d0fc and ed177c6 #### Checklist _If not applicable, provide explanation of why._ - [x] Tests updated - [also created a Jira issue to improve testing so we can pick these up in future](https://toitutewhenua.atlassian.net/browse/TDE-1218). - [x] Docs updated - [x] Issue linked in Title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
🤖 I have created a release *beep* *boop* --- ## [4.9.0](v4.8.0...v4.9.0) (2024-07-16) ### Features * Add Shapely type library TDE-1205 ([#988](#988)) ([f5e97e7](f5e97e7)) * use new pull request template ([#999](#999)) ([9a6a0b2](9a6a0b2)) ### Bug Fixes * concurrency file order TDE-1213 ([#998](#998)) ([37dcb8b](37dcb8b)) * Treat item as `dict` TDE-1209 ([#993](#993)) ([384d0fc](384d0fc)) ### Reverts * Pull Requests [#993](#993) and [#985](#985) ([#997](#997)) ([289880c](289880c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix runtime error in commands like
docker build -t topo-imagery . && docker run -v ${HOME}/tmp/:/tmp/:rw -v ${HOME}/.aws/credentials:/root/.aws/credentials:ro -e AWS_PROFILE=li-topo-prod topo-imagery python /app/scripts/collection_from_items.py --uri s3://linz-workflows-scratch/afage/small_example_dem_dataset/ --collection-id 01HYCJ3EXF37J4A9130AH7Q2RF --category dem --region hawkes-bay --gsd 1m --start-date 2023-09-20 --end-date 2023-12-21 --lifecycle ongoing --producer "Woolpert" --licensor "National Institute of Water and Atmospheric Research" --concurrency 25on topo-prod account.Modification
We load the item from a JSON file into a
dictin the production code,but none of our automated tests verify this code path, so it broke.
This partially reverts commit ed177c6.
Checklist